On Mon, Nov 26, 2012 at 03:50:30PM -0800, Junio C Hamano wrote: > Krzysztof Mazur <krzysiek@xxxxxxxxxxxx> writes: > > > On Mon, Nov 26, 2012 at 02:58:58PM -0800, Junio C Hamano wrote: > >> Krzysztof Mazur <krzysiek@xxxxxxxxxxxx> writes: > >> > >> >> Not having this new code inside "elsif (/^e/) { }" feels somewhat > >> >> sloppy, even though it is not *too* bad. Also do we know this > >> > > >> > ok, I will fix that. > >> > > >> >> function will never be used for addresses other than recipients' (I > >> >> gave a cursory look to see what is done to the $sender and it does > >> >> not seem to go through this function, tho)? > >> > > >> > Yes, this function is called only from validate_address_just() > >> > to filter @initial_to, @initial_cc, @bcc_list as early as possible, > >> > and filter @to and @cc added in each email. > >> > >> Thanks; when merged to 'pu', this series seems to break t9001. I'll > >> push the result out with breakages but could you take a look? > >> > > > > Sorry, I tested final version only on an ancient perl 5.8.8 and it really > > worked there. The third patch is broken: > > > > diff --git a/git-send-email.perl b/git-send-email.perl > > index 9996735..f3bbc16 100755 > > --- a/git-send-email.perl > > +++ b/git-send-email.perl > > @@ -1472,7 +1472,7 @@ sub unique_email_list { > > my @emails; > > > > foreach my $entry (@_) { > > - my $clean = extract_valid_address_or_die($entry)) > > + my $clean = extract_valid_address_or_die($entry); > > Ah, ok, I wasn't looking closely enough. Thanks for a quick > turnaround. Will requeue and push out. I rechecked that and I've just sent some older broken version. The patch that I've sent had date Date: Thu, 22 Nov 2012 19:00:25 +0100, but on my tree I have commit from Date: Thu Nov 22 19:01:55 2012 +0100, which is exactly the same as the fixed version in your tree. Thanks, Krzysiek -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html