On Mon, Nov 26, 2012 at 12:43 PM, Junio C Hamano <gitster@xxxxxxxxx> wrote: > Chris Rorvick <chris@xxxxxxxxxxx> writes: > >> Pass all rejection reasons back from transport_push(). The logic is >> simpler and more flexible with regard to providing useful feedback. >> >> Signed-off-by: Chris Rorvick <chris@xxxxxxxxxxx> >> --- > > In any case, naming it as "reject_mask" is like calling a counter as > "counter_int". It is more important to name it after its purpose > than after its type Agreed. > and because this is to record the reasons why > the push was rejected, "rejection_reason" might be a better name for > it. Yes, that is better for all the reasons you mention. I will fix this up. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html