SZEDER Gábor wrote: > --- a/t/t9902-completion.sh > +++ b/t/t9902-completion.sh > @@ -155,6 +155,90 @@ test_expect_success '__gitcomp - suffix' ' > test_cmp expected out > ' > > +test_expect_success '__gitcomp_nl - trailing space' ' > + sed -e "s/Z$//" >expected <<-\EOF && '$' is usually a shell metacharacter, so it would be more comfortable to read a version that escapes it: sed -e "s/Z\$//" >expected <<-\EOF Since '$/' is not a valid parameter expansion, if I understand correctly then POSIX leaves the meaning of the quoted string "s/Z$//" undefined (XCU §2.2.3). Luckily every shell I've tried, including bash, keeps the $ unmolested. Other parts of the file already use the same style, so I wouldn't suggest changing it in this patch. Thanks for some nice tests. Reviewed-by: Jonathan Nieder <jrnieder@xxxxxxxxx> -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html