Hi, These were hinted by SZEDER, so I went ahead and implemented the changes trying to keep in mind the new zsh completion werapper. The resulting code should be more efficient, and a known breakage is fixed. The first two patches come from another patch series for convenience. Take them with a pinch of salt. Felipe Contreras (5): completion: get rid of empty COMPREPLY assignments completion: add new __gitcompadd helper completion: trivial test improvement completion: get rid of compgen completion: refactor __gitcomp_1 contrib/completion/git-completion.bash | 68 +++++++++++++--------------------- t/t9902-completion.sh | 3 +- 2 files changed, 27 insertions(+), 44 deletions(-) -- 1.8.0 -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html