On Fri, Nov 16, 2012 at 12:18 PM, Felipe Contreras <felipe.contreras@xxxxxxxxx> wrote: > On Fri, Nov 16, 2012 at 4:48 PM, Marc Khouzam <marc.khouzam@xxxxxxxxx> wrote: >> On Fri, Nov 16, 2012 at 10:33 AM, Felipe Contreras >> <felipe.contreras@xxxxxxxxx> wrote: > >>> Is it possible to just check if this is a login shell? >> >> I think it would be nice to allow the user to manually >> source git-completion.tcsh, in case they want to make >> manual modifications to it. > > Yeah, they could still do that... because they would be running in a > login shell. > > What I meant is that if the user does: tcsh > my_script_that_has_nothing_to_do_with_completion.sh, they would not be > executing this whole script. Oh, I see now. I can put a check in the script for the existence of the $prompt variable. This will indicate if it is a login shell or not. However, a good .cshrc file should already have such a check to avoid sourcing a bunch of useless things. So, I personally think that we should not add it to the git-completion.tcsh script but let the tcsh user decide to do it herself. But I don't mind being overruled :) >> I think the most user-friendly option is to actually re-generate the >> script each time. It feels wrong, but it works well :) > > I'm not too strongly opposed to add that function to the bash > completion, but to do it only for tcsh doesn't sound right, specially > when there are other alternatives. I agree, and this is why I made the proposed __git_complete_with_output () generic. That way it could be used by other shells or programs. But at this time, only tcsh would make use of it. If you think having __git_complete_with_output () could be useful for others, I think we should go with solution (A). If you don't think so, or if it is better to wait until a need arises first, then solution (C) will work fine. > Correct me if I'm wrong, but very few people use tcsh. Less than I originally thought, when I started working on this patch :-\ But I'm still hoping that the those people will be a little happier with their git completion. Marc > > -- > Felipe Contreras -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html