On Fri, Nov 16, 2012 at 12:13 AM, "Jan H. Schönherr" <schnhrr@xxxxxxxxxxxxxxx> wrote: >> #define isprint(x) (sane_istest(x, GIT_ALPHA | GIT_DIGIT | GIT_SPACE | \ >> GIT_PUNCT | GIT_REGEX_SPECIAL | GIT_GLOB_SPECIAL | \ >> - GIT_PATHSPEC_MAGIC)) >> + GIT_PATHSPEC_MAGIC) && \ >> + (x) >= 32) > > May I suggest the current is_print() implementation in master: > > #define isprint(x) ((x) >= 0x20 && (x) <= 0x7e) > > > To summarize my opinion: > > I no longer see a reason to correct isspace() (unless somebody with an actual > use case complains), and a more POSIXly isprint() is already in master. > > => Nothing to do. :) Yeah. I remember to remind myself to check "the implementation in master" you mentioned but I probably failed at that. Just checked that isprint() is already in master, and your comment about isspace() use in wildmatch.c makes sense too. So I'm all for doing nothing. -- Duy -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html