On Thu, Nov 15, 2012 at 08:56:37AM -0800, Junio C Hamano wrote: > > I think a much more compelling argument/commit message for your > > suggested patch would be: > > > > We currently prompt the user for the "From" address. This is an > > inconvenience in the common case that the user has configured their > > identity in the environment, but is meant as a safety check for when > > git falls back to an implicitly generated identity (which may or may > > not be valid). > > > > That safety check is not really necessary, though, as by default > > send-email will prompt the user for a final confirmation before > > sending out any message. The likelihood that a user has both bothered > > to turn off this default _and_ not configured any identity (nor > > checked that the automatic identity is valid) is rather low. > > This somehow reminds me of the first paragraph of f20f387 (commit: > check committer identity more strictly, 2012-07-23). > > I never use "send-email driving format-patch" workflow myself, but I > suspect there are people among who do so who are using --compose to > do the cover letter of their series. Does the "confirmation as the > last step" help them, or would they have to retype their message? That is a good question. That confirmation step does come after they have typed their cover letter. However, if they are using --compose, they are dumped in their editor with something like: From Jeff King <peff@xxxxxxxx> # This line is ignored. GIT: Lines beginning in "GIT:" will be removed. GIT: Consider including an overall diffstat or table of contents GIT: for the patch you are writing. GIT: GIT: Clear the body content if you don't wish to send a summary. From: Jeff King <peff@xxxxxxxx> Subject: In-Reply-To: which I think would count as sufficient notice of the address being used. -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html