On Wed, Nov 14, 2012 at 12:05:05PM -0800, Jeff King wrote: > > When someone writes such a test, I think it could check that git > > either prompts or writes a message advising to configure the user > > email, no? Waiting until later for that seems fine to me, though. > > Yes. The problem is that the behavior and output are dependent on > factors outside the test suite, so we would have to check that one of > the possible expected outcomes happens. But I think there are really > only two such outcomes (neglecting that the ident itself can have > arbitrary content, but we do not have to check the actual content). Actually, I think the simplest thing is to add a prerequisite, like: diff --git a/t/test-lib.sh b/t/test-lib.sh index 489bc80..8d192ff 100644 --- a/t/test-lib.sh +++ b/t/test-lib.sh @@ -738,6 +738,14 @@ test_lazy_prereq UTF8_NFD_TO_NFC ' esac ' +test_lazy_prereq IMPLICIT_IDENT ' + sane_unset GIT_AUTHOR_NAME && + sane_unset GIT_AUTHOR_EMAIL && + git var GIT_AUTHOR_IDENT && + # double check that we were not polluted by config + test "$(git var GIT_AUTHOR_EXPLICIT)" = 0 +' + # When the tests are run as root, permission tests will report that # things are writable when they shouldn't be. test -w / || test_set_prereq SANITY We can't have one test machine that will cover all of the cases, but given that the test suite is run by many people across many machines, we will get coverage (and I know that some people have machines which would not pass that prereq, because I got test failure reports during the last ident refactoring). I'll include something like that in my re-roll (and it should let us test "git commit" more thoroughly, too). -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html