Johannes Schindelin <Johannes.Schindelin@xxxxxx> writes: >> The reason we did the latter, by the way, does not have anything >> to do with helping broken parsers. We drop the header after >> re-coding the log message into an encoding specified by the user >> (which is presumably different from what the commit was >> originally recorded in) because the encoding recorded on >> "encoding" header would not match the re-coded log message >> anymore. > > By the same reasoning, you'd have to rewrite the committer line to reflect > the current GIT_COMMITTER_IDENT, or hide it. If you want to convince me, > you have to try harder. Sorry, but you completely lost me with that analogy. I think showing log message in the user's preferred encoding is more like passing the output to the colorization mechanism and then to the pager. We are interacting with humans at that point, and we are changing the presentation without changing the semantics of the data. I do not see why committer identity needs to be rewritten nor hidden by the same reasoning. > And Marco has to fix the header parsing anyway. No question about that. If iconv() punts, qgit will see "encoding" header to deal with even when the re-coding is in effect. I think it may be a sensible thing for qgit to replace the log message and show "log message in this encoding, which cannot be shown in this window" instead in such a case, but that is up to Porcelain. - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html