Max Horn wrote: > Aha, now I understand what this patch is about. So I would suggest > this alternate commit message: > > remote-testgit: make it explicit clear that we use the 'done' feature > > Previously we relied on passing '--use-done-feature ' to git > fast-export, which is easy to miss when looking at this script. I'm not immediately sure I agree this is even a problem. Is the point that other fast-import frontends do not have a --use-done-feature switch, so a typical remote helper has to do that work itself, and the sample "testgit" remote helper would be a more helpful example by doing that work itself? The idea behind --use-done-feature is that if fast-export exits early for some reason and its output is going to a pipe then at least the stream will be malformed, making it easier to catch errors. So there is something to be weighed here: is it more important to illustrate how to make your fast-export tool's output prefix-free, or is it more important to illustrate how to work around a fast-export tool that doesn't support that feature? The answer is not immediately obvious to me. A good description could provide context to make it obvious. Hoping that clarifies, Jonathan -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html