On Sun, Nov 11, 2012 at 03:24:19PM -0500, Paul Fox wrote: > krzysztof wrote: > > Looks ok, but what about SIGQUIT? Some editors like GNU ed (0.4 and 1.6) > > ignore SIGQUIT, and after SIGQUIT git dies, but editor is still running. > > After pressing any key ed receives -EIO and prints "stdin: Input/output > > error". GNU ed 1.6 then exits, but ed 0.4 prints this error forever. > > Maybe git should kill the editor in such case? > > there's certainly lots of precedent for treating SIGINT and SIGQUIT > the same. but there's also some merit to saying that if the user > knows to send SIGQUIT instead of SIGINT, they may well have a reason. > (after all, if we always treat them the same, there's no point in > having both.) That's why I'm proposing in case of SIGQUIT just killing the editor (SIGTERM is sufficient for ed). So git will ignore SIGINT, but die on SIGQUIT (and kill editor that ignores SIGQUIT). > > the em editor (linus' microemacs) behaves as you describe ed 0.4 does, > except without the error message -- it just spins silently getting EIO > from reading stdin. i think em needs to be fixed, and it sounds like > GNU ed already has been. (unless i misunderstand the relationship of > 0.4 and 1.6.) Yes, the version 1.6 is fixed, it just prints an error once and exits. Krzysiek -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html