Re: [PATCH v5 01/15] fast-export: avoid importing blob marks

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Nov 11, 2012 at 05:36:53PM +0100, Torsten Bögershausen wrote:

> On 11.11.12 14:59, Felipe Contreras wrote:
> > test_expect_success 'test biridectionality' '
> > +	echo -n > marks-cur &&
> > +	echo -n > marks-new &&
> Unless I messed up the patch:
> 
> Minor issue: still a typo "biridectionality"
> Major issue:  "echo -n" is still not portable.
> 
> Could we simply use
> 
> touch  marks-cur  &&
> touch marks-new

Yes, "echo -n" is definitely not portable.  Our preferred way of
creating an empty file is just ">file".

-Peff
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]