On Mon, Oct 29, 2012 at 10:47:04PM +0100, Felipe Contreras wrote: > >> Yeah, the test script is not ready for merging, it needs to check for > >> python, hg, and hg-git. > >> > >> Do you have hg-git installed? > > > > No. But it's important that it fail gracefully; I can't even take it in > > pu if I can't run the test suite in a sane way. > > The contrib part is fine for 'pu'. The tests aren't even meant to > exercise stuff in 'contrib', right? There might be some exceptions, > but either way, there's plenty of stuff in 'contrib' without any > tests. The tests I'm providing are simply a little sugar. Yeah, contrib is a bit of a wildcard. Most things do not have tests. Completion tests run as part of the main test suite (which to me means that completion should arguably be promoted out of contrib). Subtree carries its own tests that build on the test suite, but do not run all the time. If remote-hg is going to live in contrib, it probably makes sense to have its tests live there, too, like subtree. It means less test exposure, but the robustness of the tests does not have to be as high. You could also have no tests, but since you have them, it seems silly not to include them. People know that items in contrib/ may not be as mature as the rest of git. -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html