On Sun, Oct 28, 2012 at 10:37:16PM +0100, Jens Lehmann wrote: > When renaming orig_args to orig_flags in 98dbe63d (submodule: only > preserve flags across recursive status/update invocations) the call site > of the recursive cmd_status was forgotten. At that place orig_args is > still passed into the recursion, which is always empty since then. This > did not break anything because the orig_flags logic is not needed at all > when a function from the submodule script is called with eval, as that > inherits all the variables set by the option parsing done in the first > level of the recursion. > > Now that we know that orig_flags and orig_args aren't needed at all, > let's just remove them from cmd_status(). > > Thanks-to: Phil Hord <hordp@xxxxxxxxx> > Signed-off-by: Jens Lehmann <Jens.Lehmann@xxxxxx> I'll replace your earlier fix (which just fixes the s/args/flags/ and adds a test) with Phil's patch, and this on top. Thanks. -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html