On Fri, Oct 26, 2012 at 03:33:27PM +0200, Michael J Gruber wrote: > for (p = argv; *p; p++) { > - if (snprintf(ref, sizeof(ref), "refs/replace/%s", *p) > + q = *p; > + if (get_sha1(q, sha1)) > + warning("Failed to resolve '%s' as a valid ref; taking it literally.", q); > + else > + q = sha1_to_hex(sha1); Doesn't get_sha1 already handle this for 40-byte sha1s (and for anything else, it would not work anyway)? -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html