Sparse issues a warning for all six external symbols defined in this file. In order to suppress the warnings, we include the 'pathspec.h' header file, which contains the relevant extern declarations for these symbols. Signed-off-by: Ramsay Jones <ramsay@xxxxxxxxxxxxxxxxxxx> --- Hi Nguyen, I asked Adam to squash this patch into his 'as/check-ignore' branch when he next re-rolled the branch. However, it appears that you resubmitted that branch instead ... :-D I don't know if this branch is ready to progress to next yet, but could somebody (yourself, Adam or Jeff?) please squash this into commit 1a88ae42 ("pathspec.c: move reusable code from builtin/add.c") before it hits next. Thanks! ATB, Ramsay Jones pathspec.c | 1 + 1 file changed, 1 insertion(+) diff --git a/pathspec.c b/pathspec.c index a9c5b5b..efdabe4 100644 --- a/pathspec.c +++ b/pathspec.c @@ -1,5 +1,6 @@ #include "cache.h" #include "dir.h" +#include "pathspec.h" void validate_path(const char *prefix, const char *path) { -- 1.8.0 -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html