On Sun, Oct 28, 2012 at 08:01:04AM -0400, Jeff King wrote: > -G operates on the munged data; you can see it feed the munged data to > xdiff in diff_grep. But the optimization for handling added and removed > files accidentally fed the wrong pointer. Fixing that is a no-brainer, > since the optimization is inconsistent with the regular code path. > > -S, however, predates the invention of textconv and has never used it. > It is a little less clear that textconv is the right thing here, because > it is not about grepping the diff, but about counting occurrences of the > string inside the file content. I tend to think that doing so on the > textconv'd data would be what people generally want, but it is a > behavior change. I prepared the earlier bugfix for "-G" for maint. Modifying "-S" would be a separate feature topic, and would look like this (I built it on top of the bugfix patch, since the tests are a follow-on). [1/2]: pickaxe: hoist empty needle check [2/2]: pickaxe: use textconv for -S counting -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html