On Sat, Oct 27, 2012 at 7:33 PM, Junio C Hamano <gitster@xxxxxxxxx> wrote: > > > Nguyen Thai Ngoc Duy <pclouds@xxxxxxxxx> wrote: >> >>Notice the --cc in the first line, which is combined diff. Usually >>combined-diff is between two points and one parent. Though somehow git >>passes 4 parents down combined-diff.c:show_combined_header, as you can >>see in the "index" line. I think we should fix rev parsing code as it >>does not make sense to pass 4 identical parents this way. > > The two heads home from HEAD...HEAD the user has on the command line. > > The user is getting exactly what she asked; there is nothing to fix. Is there any use case where HEAD...HEAD (or "..." alone) is actually useful? I have re-read the git-diff man page and I don't think it explains "git diff foo ... bar" syntax (from a user's point of view, not a git guru's). We could improve the documentation if "git diff foo ... bar" is useful, or reject it with an error to avoid confusion. -- Duy -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html