Am 26.10.2012 19:55, schrieb Phil Hord: > On Fri, Oct 26, 2012 at 1:19 PM, Phil Hord <hordp@xxxxxxxxx> wrote: >> >> Yes, thanks for catching that. I think I should add a test for that >> except I notice that sync doesn't take any other flags useful for passing. > > Which, of course, suggests that I should not add this > flag-propagating-machinery to submodule-sync at all. yes? Nope, the new --recursive option has to be passed on! To catch that bug in your test you'd need another submodule inside your sub-submodule. The first level submodule is initialized by sync anyways, the sub-submodule is initialized by the --recursive logic you added but the sub-sub-submodule would not have been synced because the option was dropped. I really can't blame you for not adding that third level of submodules ;-) -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html