Hi, On Thu, Oct 25, 2012 at 4:41 AM, Matt Arsenault <arsenm2@xxxxxxxxx> wrote: > > On Oct 21, 2012, at 12:06 , Junio C Hamano <gitster@xxxxxxxxx> wrote: >> >> - Why is it a bug not to pass "-s"? How does the bug happen? > > I encountered this one time after using it for months. One day I couldn't git p4 rebase > with the key error. I searched for the error and found some version of git-p4 that fixed > a similar error by adding the -s to describe. Adding the -s fixed the error and > everything seemed to be working correctly. The perforce documentation says the following about this flag: "The -s flag omits the diffs of files that were updated." So if the diffs are not used, there is no downside to use -s. Maybe the patch should just state this. Best, Christian. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html