Re: [PATCH] gitk: Fix crash when not using themed widgets

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Oct 07, 2012 at 11:21:14PM +0200, Marcus Karlsson wrote:
> When configured not to use themed widgets gitk may crash on launch with
> a message that says that the image "bm-left disabled bm-left-gray"
> doesn't exist. This happens when the left and right arrow buttons are
> created.
> 
> The crash can be avoided by configuring the buttons differently
> depending on whether or not themed widgets are used. If themed widgets
> are not used then only set the images to bm-left and bm-right
> respectively, and keep the old behavior when themed widgets are used.
> 
> The previous behaviour was added in f062e50f to work around a bug in Tk
> on OS X where the disabled state did not display properly. The buttons
> may still not display correctly, however the workaround added in
> f062e50f will still apply if gitk is used with themed widgets.
> 
> Make gitk not crash on launch when not using themed widgets.
> 
> Signed-off-by: Marcus Karlsson <mk@xxxxxxxxxx>

Thanks, applied.

Paul.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]