Jeff King venit, vidit, dixit 17.10.2012 21:05: > On Wed, Oct 17, 2012 at 07:30:56AM -0600, Eric Blake wrote: > >>> We've talked about it several times, but it's never happened (probably >>> because most people don't actually use notes). >> >> And people (like me) don't use notes because they aren't documented. >> Catch-22, so we have to start somewhere. > > Oh, I definitely agree your patch is the right direction. I was just > explaining why it hasn't happened, even though people think it's a good > idea. > >> I'll submit a v2 with the non-controversial edits, and spend some time >> trying to figure out how to isolate the portion of pretty-options.txt >> that is relevant to format-patch. If it's easy enough, I can also >> consider using --- instead of Notes: as the separator when using >> format-patch. > > Hmm. After digging in the archive, it seems we (including both you and > me!) have discussed this several times, and there are even some patches > floating around. Maybe one of them would be a good starting point for > your submission (I did not read carefully over all of the arguments for > each): > > Patch from Thomas, Feb 2010: > > http://thread.gmane.org/gmane.comp.version-control.git/139919/focus=140818 > > Discussion between us, Dec 2010: > > http://thread.gmane.org/gmane.comp.version-control.git/163141 > > Patch from Michael, Apr 2011: > > http://thread.gmane.org/gmane.comp.version-control.git/172079 That one used to work for about one more year or so (it went through a few rebases) but stopped working during some rework involving the signature (signed-off-by), i.e. it puts the notes before the signed-off now. I didn't update it because nobody seemed interested anyway (and because branch-notes got implemented in a different, non-note way, so I dumped that part of my workflow also). Michael -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html