On Wed, Oct 17, 2012 at 10:45:22PM -0700, Junio C Hamano wrote: > We never advertised the "--notes" option to format-patch (or > anything related to the pretty format options for that matter) > because the behaviour of these options was whatever they happened to > do, not what they were designed to do. > > It had a few obvious glitches: > > * The notes section was appended immediately after the log message, > and then the three-dash line was added. Such a supplimental > material should come after the three-dash line. > > * The logic to append a new sign-off with "format-patch --signoff" > worked on the message after the note was added, which made the > detection of existing sign-off lines incorrect. > > This updates the handling of "--notes" option to correct these, in > an attempt to bring it closer to a real feature. I just read through the whole series. Aside from the tangent about strbuf_detach, I didn't see anything wrong. Thanks for moving this forward. -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html