"Shawn O. Pearce" <spearce@xxxxxxxxxxx> writes: > Junio C Hamano <junkio@xxxxxxx> wrote: >> "Shawn O. Pearce" <spearce@xxxxxxxxxxx> writes: >> >> > Junio C Hamano <junkio@xxxxxxx> wrote: >> > >> >> Why? Are you allowing "1024 k"? Do we want to? >> > >> > Yes. Why not? >> >> Stricter input checking. Allowing extra things later is far >> easier than later finding problems with a looser way we started >> from and having to tighten it. > > Good point. I'm currently writing tests for this btw. I have this already in the private 'master' I am prepareing for pushout: diff --git a/t/t1300-repo-config.sh b/t/t1300-repo-config.sh index e48a4ec..a29caa0 100755 --- a/t/t1300-repo-config.sh +++ b/t/t1300-repo-config.sh @@ -391,5 +391,15 @@ EOF test_expect_success "rename succeeded" "diff -u expect .git/config" +test_expect_success numbers ' + + git-repo-config kilo.gram 1k && + git-repo-config mega.ton 1m && + k=$(git-repo-config --int --get kilo.gram) && + test z1024 = "z$k" && + m=$(git-repo-config --int --get mega.ton) && + test z1048576 = "z$m" +' + test_done -- 1.5.0.rc0.g81760 - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html