On Thu, Oct 18, 2012 at 07:31:35AM +0200, Johannes Sixt wrote: > Right. But we should really be doing something like this instead to save a > few subprocesses. > [...] > - eval "$(set_ident AUTHOR <../commit)" || > + eval "$(set_ident AUTHOR author <../commit)" || I cringe a little at losing DRY-ness to avoid processes. But the repetition is pretty straightforward and obvious, and I know that some platforms are really hurt by extra processes (and this is being called for every commit). Speaking of repetition, this seems like almost the exact same parsing that happens in git-sh-setup's get_author_ident_from_commit. Maybe it's worth merging them. I suspect you could also avoid another process by parsing out both author and committer information in the same sed invocation. -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html