Re: [PATCH 3/3] Use /dev/null for update hook stdin.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



"Shawn O. Pearce" <spearce@xxxxxxxxxxx> writes:

> Currently the update hook invoked by receive-pack has its stdin
> connected to the pushing client.  The hook shouldn't attempt to
> read from this stream, and doing so may consume data that was
> meant for receive-pack.  Instead we should give the update hook
> /dev/null as its stdin, ensuring that it always receives EOF and
> doesn't disrupt the protocol if it attempts to read any data.

Both 2 and 3 look sane, but can we have a few new tests too?

-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]