Hi,
On Sun, Oct 14, 2012 at 06:14:03PM +0200, Felipe Contreras wrote:
> Signed-off-by: Felipe Contreras <felipe.contreras@xxxxxxxxx>
> ---
> contrib/completion/git-completion.bash | 35 +++++++++++++++++-----------------
> t/t9902-completion.sh | 21 ++++++++++++++++++++
> 2 files changed, 39 insertions(+), 17 deletions(-)
>
> diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
> index d743e56..2a83504 100644
> --- a/contrib/completion/git-completion.bash
> +++ b/contrib/completion/git-completion.bash
This patch doesn't apply on current master.
> @@ -1559,11 +1559,12 @@ _git_send_email ()
> --signed-off-by-cc --smtp-pass --smtp-server
> --smtp-server-port --smtp-encryption= --smtp-user
> --subject --suppress-cc= --suppress-from --thread --to
> - --validate --no-validate"
> + --validate --no-validate
> + $__git_format_patch_options"
> return
> ;;
> esac
> - COMPREPLY=()
> + __git_complete_revlist_file
While send-email accepts a rev-list, it doesn't accept
'HEAD:Documentation', does it? So __git_complete_revlist() would be
better here, because that makes the intent clear.
> }
>
> _git_stage ()
> diff --git a/t/t9902-completion.sh b/t/t9902-completion.sh
> index 92d7eb4..c4b6c13 100755
> --- a/t/t9902-completion.sh
> +++ b/t/t9902-completion.sh
> @@ -146,6 +146,22 @@ test_expect_success '__gitcomp - suffix' '
> test_cmp expected out
> '
>
> +setup_repository ()
> +{
> + mkdir "$1" && (
> + cd "$1" &&
> + git init &&
> + test_tick &&
> + git commit --allow-empty -m "Initial"
> + )
> +}
> +
> +test_expect_success 'prepare' '
> + setup_repository one &&
> + git clone one test &&
Why are these new repositories needed?
> + cd test
This 'cd' makes all subsequent tests to be executed in a different
repository than previously, which breaks 'checkout completes ref
names'.
> +'
> +
> test_expect_success 'basic' '
> run_completion "git \"\"" &&
> # built-in
> @@ -228,4 +244,9 @@ test_expect_success 'general options plus command' '
> test_completion "git --no-replace-objects check" "checkout "
> '
>
> +test_expect_success 'send-email' '
> + test_completion "git send-email --cov" "--cover-letter " &&
> + test_completion "git send-email ma" "master "
> +'
> +
> test_done
> --
> 1.7.12.1
>
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html