On 10/15/2012 11:39 AM, Junio C Hamano wrote:
Thanks for bringing some sanity to the color of the bikeshed ;-)
As I don't use colors very much, I didn't bother checking the color
assignment in the patch in question, but everything you said in your
response makes 100% sense, including the traffic light analogy.
Hi Junio, Michael
The point of the thread and the patch was to enable the possibility of
colors in the prompt without messing it up.
The actual colors used are more or less how I'm used to it, but as you
said they may not be suitable to everyone.
@Junio, is this patch something you want to include as it is now (with
the extra S that Michael pointed out) or do you want to wait for a
discussion about which colors to use for which state?
I guess it could be quite a messy discussion, as you already hint at
bikeshed colors, it's quite personal and subjective.
As a start, I think it's worth considering what the color would actually
mean.
To me:
A neutral color should mean it's safe to switch branches or merge/update
A non-neutral color would mean some action is required before switching
branches.
There are various states that may or may not get in the way of
switching, like stashed stuff or divergence from upstream. I think these
could get a color hint, but I'm not sure what kind.
Cheers
Simon
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html