Shawn Pearce <spearce@xxxxxxxxxxx> writes: >> Also can we fix the definition of core.packedGitWindowSize to be >> independent of the page size on a particular platform? > > What do you mean? mmap() only works in page units, and because of > the way the code is built the minimum size we can allow is 2 pages. > > Asking mmap() to map less than a full page in the last page of > a given window is silly, as that is just going to waste virtual > address space or cause pain for the OS, depending on how that > gets implemented. Ah, I misread the code. I thought the value is integer that states number of pages, but you are only rounding it down and enforcing two-page minimum. Sorry for the noise. - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html