Until Subversion 1.7 (more precisely r873487), the standard way to
canonicalize a URI was to call svn_path_canonicalize(). Use it.
This saves "git svn" from having to rely on our imperfect
reimplementation of the same. If the function doesn't exist or
returns undef, though, it can use the fallback code, which we keep to
be conservative. Since svn_path_canonicalize() was added before
Subversion 1.1, hopefully that doesn't happen often.
Signed-off-by: Jonathan Nieder <jrnieder@xxxxxxxxx>
---
perl/Git/SVN/Utils.pm | 12 ++++++++----
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/perl/Git/SVN/Utils.pm b/perl/Git/SVN/Utils.pm
index 3d1a0933..40f7c799 100644
--- a/perl/Git/SVN/Utils.pm
+++ b/perl/Git/SVN/Utils.pm
@@ -138,15 +138,19 @@ API as a URL.
sub canonicalize_url {
my $url = shift;
+ my $rv;
# The 1.7 way to do it
if ( defined &SVN::_Core::svn_uri_canonicalize ) {
- return SVN::_Core::svn_uri_canonicalize($url);
+ $rv = SVN::_Core::svn_uri_canonicalize($url);
}
- # There wasn't a 1.6 way to do it, so we do it ourself.
- else {
- return _canonicalize_url_ourselves($url);
+ # The 1.6 way to do it
+ elsif ( defined &SVN::_Core::svn_path_canonicalize ) {
+ $rv = SVN::_Core::svn_path_canonicalize($url);
}
+ return $rv if defined $rv;
+
+ return _canonicalize_url_ourselves($url);
}
--
1.8.0.rc2
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html