On 10/10/2012 06:52 PM, Junio C Hamano wrote: > Michael Haggerty <mhagger@xxxxxxxxxxxx> writes: > >>> The last one teaches "git log" family to honor the "grep.*" >>> configuration variables, e.g. "grep.patterntype", so that you can >>> say "git -c grep.patterntype=perl log --grep='(?:pcre)'". >> >> Maybe this has been discussed already, but it seems to me that adding a >> persistent setting that affects how "git log --grep" interprets the >> pattern argument could break some scripts that assume that the "old" >> interpretation is always used. Shouldn't this at least be documented as >> a backwards incompatibility? > > If somebody scripts around "log" with hardcoded query "--grep=..." > strings, they can force a particular variant from such a command > line at the same time. But as always, responsibility of doing so is > on the person who writes such a script; "log" being a Porcelain, we > value ease-of-use in interactive case more than cast-in-stone > interface stability like we do for plumbing commands. > > And that is exactly why the series avoids changing the behaviour for > the "rev-list" plumbing. OK, you've convinced me. Thanks. Michael -- Michael Haggerty mhagger@xxxxxxxxxxxx http://softwareswirl.blogspot.com/ -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html