On Wed, Oct 10, 2012 at 3:47 AM, Junio C Hamano <gitster@xxxxxxxxx> wrote: > Nguyễn Thái Ngọc Duy <pclouds@xxxxxxxxx> writes: > >> diff --git a/wildmatch.c b/wildmatch.c >> index 7b64a6b..2382873 100644 >> --- a/wildmatch.c >> +++ b/wildmatch.c >> @@ -11,8 +11,8 @@ >> >> #include <stddef.h> >> #include <ctype.h> >> -#include <string.h> >> >> +#include "cache.h" >> #include "wildmatch.h" > > This is wrong; the includes from the system headers should have > been removed in the previous step where the series "integrated" > wildmatch to git, after which point the first include any C source > that is not at the platform-compatibility layer should be cache.h > or git-compat-util.h. Git's ctype does not seem to be complete for wildmatch's use so ctype.h is required. But that can be easily fixed later on. -- Duy -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html