On 9 October 2012 19:05, Junio C Hamano <gitster@xxxxxxxxx> wrote:
> Øyvind A. Holm <sunny@xxxxxxxxxxx> writes:
> > 40bfbde ("build: don't duplicate substitution of make variables",
> > 2012-09-11) breaks make by removing a necessary comma at the end of
> > "CC_LD_DYNPATH=-rpath" in line 414 and 423.
>
> The earlier one is a cut-and-paste-error regression.
>
> Isn't the one at line 423 from before 40bfbde, though? If that is the
> case, I'm a bit hesitant to take that part of this patch without a
> second opinion.
It looks like it is, yes. More accurately, from 798a945 way back in
2008. If it hasn't caused any trouble since then, it probably won't. :)
The line was changed in 40bfbde, though, but AC_SUBST doesn't contain a
comma, so to be on the safe side, the first patch should be used.
But I made a minor copy+paste error in the commit message of that patch:
"CC_LD_DYNPATH=-rpath" in line 414.
should be
"CC_LD_DYNPATH=-Wl,-rpath" in line 414.
Just a minor, but slightly annoying detail.
Regards,
Øyvind
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html