Re: [PATCH] t/t5400-send-pack: Use POSIX options to cp for portability

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Junio C Hamano <gitster@xxxxxxxxx> writes:

> Ben Walton <bdwalton@xxxxxxxxx> writes:
>
>> Avoid a GNU-ism in the cp options used by t5400-send-pack.  Change -a
>> to -pR.
>>
>> Signed-off-by: Ben Walton <bdwalton@xxxxxxxxx>
>> ---
>
> Thanks, but is "-p" essential for this test to pass, or can we get
> away with just "-R"?

Besides, when you spot a potential problem, please ask "git grep"
to catch them all.

    $ git grep "cp -a" t/
    t/t5400-send-pack.sh:   cp -a parent child &&
    t/t5550-http-fetch.sh:  cp -a .git"$HTTPD_DOCUMENT_ROOT_PATH/repo.git" &&
    t/t5800-remote-helpers.sh:      cp -a server server2 &&

>>  t/t5400-send-pack.sh | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/t/t5400-send-pack.sh b/t/t5400-send-pack.sh
>> index 250c720..65b3b0f 100755
>> --- a/t/t5400-send-pack.sh
>> +++ b/t/t5400-send-pack.sh
>> @@ -159,7 +159,7 @@ test_expect_success 'receive-pack runs auto-gc in remote repo' '
>>  	    git commit -a -m "Second commit" &&
>>  	    git repack
>>  	) &&
>> -	cp -a parent child &&
>> +	cp -pR parent child &&
>>  	(
>>  	    # Set the child to auto-pack if more than one pack exists
>>  	    cd child &&

--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]