Junio C Hamano <gitster@xxxxxxxxx> writes: > Jeff King <peff@xxxxxxxx> writes: > >> Why not do it like this: >> >> diff --git a/Documentation/Makefile b/Documentation/Makefile >> index 267dfe1..ca10313 100644 >> --- a/Documentation/Makefile >> +++ b/Documentation/Makefile >> @@ -152,7 +152,8 @@ endif >> endif >> endif >> >> -all: html man >> +DEFAULT_DOC_TARGET ?= html man >> +all: $(DEFAULT_DOC_TARGET) >> >> html: $(DOC_HTML) >> >> >> which covers both cases? That is also how we handle DEFAULT_TEST_TARGET. > > Surely, and thanks. So here is a proposed update based on your idea, to be squashed on top (i.e. the change to the top-level Makefile in the posted patch is not reverted). Does it make sense? Documentation/Makefile | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git c/Documentation/Makefile w/Documentation/Makefile index 063fa69..0f8fdf8 100644 --- c/Documentation/Makefile +++ w/Documentation/Makefile @@ -1,3 +1,6 @@ +# The default target of this Makefile is... +all:: + MAN1_TXT= \ $(filter-out $(addsuffix .txt, $(ARTICLES) $(SP_ARTICLES)), \ $(wildcard git-*.txt)) \ @@ -65,6 +68,8 @@ endif -include ../config.mak.autogen -include ../config.mak +DEFAULT_DOC_TARGET ?= html man + # # For docbook-xsl ... # -1.68.1, no extra settings are needed? @@ -151,7 +156,7 @@ ifndef V endif endif -all: html man +all:: $(DEFAULT_DOC_TARGET) html: $(DOC_HTML) -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html