Jeff King <peff@xxxxxxxx> writes: > Agreed. Maybe the simplest thing would be to have grep_config fill in a > "static struct grep_opt grep_defaults", and then memcpy that into place > during init_revisions? Yes, I was doing that for a bit last night, but then realized that the grep_config() should be split into two (grep specific part and then the bits that cascade to others, which is "git grep" specific requirement; it is far better to let other callers to arrange the cascading themselves) before moving the grep specific bit to the top-level, so that needs to come first. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html