This fixes another regression that was introduced in b967135 ("gitk: Synchronize highlighting in file view when scrolling diff"): when searching for a string in tree mode, jumping to the next search hit would highlight the "Comments" entry in the file list. Signed-off-by: Stefan Haller <stefan@xxxxxxxxxxxxxxxx> --- gitk | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/gitk b/gitk index 8935284..0ee5585 100755 --- a/gitk +++ b/gitk @@ -7967,8 +7967,9 @@ proc highlightfile {cline} { } proc highlightfile_for_scrollpos {topidx} { - global difffilestart + global cmitmode difffilestart + if {$cmitmode eq "tree"} return if {![info exists difffilestart]} return set top [lindex [split $topidx .] 0] @@ -8192,12 +8193,10 @@ proc scrolltext {f0 f1} { global searchstring cmitmode ctext global suppress_highlighting_file_for_this_scrollpos - if {$cmitmode ne "tree"} { - set topidx [$ctext index @0,0] - if {![info exists suppress_highlighting_file_for_this_scrollpos] - || $topidx ne $suppress_highlighting_file_for_this_scrollpos} { - highlightfile_for_scrollpos $topidx - } + set topidx [$ctext index @0,0] + if {![info exists suppress_highlighting_file_for_this_scrollpos] + || $topidx ne $suppress_highlighting_file_for_this_scrollpos} { + highlightfile_for_scrollpos $topidx } catch {unset suppress_highlighting_file_for_this_scrollpos} -- 1.8.0.rc0.36.gef0f079 -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html