On Thu, Oct 04, 2012 at 09:46:42AM -0700, Junio C Hamano wrote: > Jeff King <peff@xxxxxxxx> writes: > > > Hmm. So I think this is a nice feature for some people, but I wonder if > > we would run into any plumbing compatibility issues. People do tend to > > use "log" as plumbing (since rev-list is not as capable). On the other > > hand, I'd think most internal uses of "log --grep" would be passing > > something along from the user, and the user would be happy to have it > > interpreted by their chosen set of rules. > > This does make "rev-list --grep" aware of the configuration but at > the same time --basic-regexp and friends are also available to it. Does it? I thought the patch only tweaked git_log_config. Am I misreading? Having --basic-regexp is a nice escape hatch, but it would be a regression for older scripts which were written before --basic-regexp existed (or was necessary). -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html