On Thu, Oct 4, 2012 at 10:04 AM, Jeff King <peff@xxxxxxxx> wrote: > On Thu, Oct 04, 2012 at 03:56:09AM -0400, Jeff King wrote: > >> [1/4]: peel_ref: use faster deref_tag_noverify >> [2/4]: peel_ref: do not return a null sha1 >> [3/4]: peel_ref: check object type before loading >> [4/4]: upload-pack: use peel_ref for ref advertisements > > I included my own timings in the final one, but my "pathological" case > at the end is a somewhat made-up attempt to emulate what you described. > Can you double-check that this series still has a nice impact on your > real-world repository? It does, here's best of five for, all compiled with -g -O3: v1.7.8: $ time (echo 0000 | ~/g/git/git-upload-pack . | pv >/dev/null) 3.49MB 0:00:00 [ 5.3MB/s] [ <=> ] real 0m0.660s user 0m0.604s sys 0m0.248s master without your patches: $ time (echo 0000 | ~/g/git/git-upload-pack . | pv >/dev/null) 3.49MB 0:00:00 [10.2MB/s] [ <=> ] real 0m0.344s user 0m0.300s sys 0m0.172s master with your patches: $ time (echo 0000 | ~/g/git/git-upload-pack . | pv >/dev/null) 3.49MB 0:00:00 [31.8MB/s] [ <=> ] real 0m0.113s user 0m0.088s sys 0m0.088s -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html