Junio C Hamano <gitster@xxxxxxxxx> writes: >> I agree that it's ugly. How about the following: >> >> I modified __git_ps1 to work both in PROMPT_COMMAND mode and in that >> mode support color hints. >> >> This way there's one function, so no overlap. > > I think the logical progression would be > > - there are parts of __git_ps1 you want to reuse for your > __git_ps1_pc; separate that part out as a helper function, > and make __git_ps1 call it, without changing what __git_ps1 > does (i.e. no colors, etc.) > > - add __git_ps1_pc that uses the helper function you separated > out. > > - add whatever bells and whistles that are useful for users of > either __git_ps1 or __git_ps1_pc to that helper function. Hrm, let me ask a stupid question. Why do we even need __git_ps1_pc in the first place? Wouldn't it be just the matter of PROMPT_COMMAND='__git_ps1 "%s"' once you have __git_ps1 that works? -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html