Junio C Hamano <junkio@xxxxxxx> wrote: > "Shawn O. Pearce" <spearce@xxxxxxxxxxx> writes: > > > The new --reflog-action for git-reset behaves like the same option > > to git-merge; it can be used by the caller to override the message > > entry in the reflog and is intended to be used only when git-reset > > is acting as plumbing, not porcelain. > > Honestly, I hate these --reflog-action options everywhere. Me too. Yet I submit patches to add them. ;-) > Then calls to "git-update-ref -m" could use the value of > "$GIT_REFLOG_ACTION", without explicit --reflog-action= > parameters and $rloga variables. I agree. Your suggestion is way more elegant. I have some more git-am/git-merge/git-pull/git-rebase patches brewing; I'm finishing the commit message for the last in the sequence. I'll update it to include your suggestion and try to start cleaning up this --reflog-action mess, then ship the series out to the list, including this mini 2 patch series you are rejecting for good reason. -- Shawn. - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html