Re: [PATCH] submodule: configure submodule.<name>.path on add and init

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Am 24.09.2012 21:30, schrieb Orgad Shaneh:
> In order to read diff options for a submodule, its path must be configured
> ---
>  git-submodule.sh |    2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/git-submodule.sh b/git-submodule.sh
> index 3e2045e..f97bb62 100755
> --- a/git-submodule.sh
> +++ b/git-submodule.sh
> @@ -359,6 +359,7 @@ Use -f if you really want to add it." >&2
>  			esac
>  		) || die "$(eval_gettext "Unable to checkout submodule '\$sm_path'")"
>  	fi
> +	git config submodule."$sm_path".path "$sm_path"
>  	git config submodule."$sm_path".url "$realrepo"
>  
>  	git add $force "$sm_path" ||
> @@ -476,6 +477,7 @@ cmd_init()
>  				url=$(resolve_relative_url "$url") || exit
>  				;;
>  			esac
> +			git config submodule."$name".path "$name" ||
>  			git config submodule."$name".url "$url" ||
>  			die "$(eval_gettext "Failed to register url for submodule path '\$sm_path'")"

Nack. The path must only be configured in .gitmodules or we'll
never be able to rename the submodule directory.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]