Ryan Cumming <etaoins@xxxxxxxxx> writes: > From: Ryan Cumming <etaoins@xxxxxxxxx> > > git p4 was moved out of contrib in 1.7.11 but it git-completion didn't > know about it. Add git p4 completion based on the existing SVN > completion. It covers all known subcommands and options except for the > -/ option for clone which doesn't use the standard -- prefix. > > Signed-off-by: Ryan Cumming <etaoins@xxxxxxxxx> > --- Sounds sensible; thanks. > +_git_p4 () > +{ > +... > + local submit_opts=" > + --origin= -M --preserve-user --export-labels > + $common_opts > + " > + > + case "$subcommand,$cur" in > ... > + submit,--*) > + __gitcomp "$submit_opts" This is taken when $cur begins with --, but $submit_opts includes "-M" which doesn't begin with it. Is that a problem? > + ;; > + submit,*) > + __gitcomp "$(__git_refs)" > + ;; > + esac > + fi > +} -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html