Re: GIT_DIR vs. --git-dir

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Nguyen Thai Ngoc Duy <pclouds@xxxxxxxxx> writes:

> "~" is a shell feature. Know your shell. If we make an exception for
> --git-dir, we might have to support --blahblah=~/somewhere.

Correct but not entirely true.

When we know --git-dir=<path> must name a path, we should be able to
do better.  See OPT_FILENAME in >parse-optios.h>, for inspiration.

MJG's patch later in this thread is conceptually OK but I do not
think it should introduce a "expand and then setenv" helper that
won't be useful unless the variable is GIT_DIR.  That pattern does
not appear that often, and smells like a bad API design taste.


--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]