Hi, Jeff King wrote: > On Sat, Sep 22, 2012 at 02:22:46AM +0530, Ramkumar Ramachandra wrote: > >> Replace $SHELL with an explicit `/bin/sh`, as some shells do not >> support all the features used in the script. For example, ZSH does >> not respect IFS, which is used in line 478. > > I don't think that is the right thing to do. The point of SHELL is to > point at a bourne-compatible shell. On some systems, the main reason to > set it is that /bin/sh is _broken_, and we are trying to avoid it. But you're only avoiding it in the --tee/ --va* codepath. In the normal codepath, you're stuck with /bin/sh anyway. > A bigger question is: why are you setting SHELL=zsh in the first place? I use ZSH as my primary shell, so SHELL is set to zsh when I run tests. How can we trust $SHELL to be a bourne-compatible shell? Ram -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html