Re: [RFC/PATCH 6/6] gitweb: Make possible to run under mod_perl without ParseHeaders

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Robert Fitzsimons wrote:
>> @@ -1854,7 +1976,8 @@ EOF
>>  		      $cgi->hidden(-name => "a") . "\n" .
>>  		      $cgi->hidden(-name => "h") . "\n" .
>>  		      $cgi->popup_menu(-name => 'st', -default => 'commit',
>> -				       -values => ['commit', 'author', 'committer', 'pickaxe']) .
>> +		                       -values => ['commit', 'author', 'committer',
>> +		                       gitweb_check_feature('pickaxe') ? 'pickaxe' : ()]) .
>>  		      $cgi->sup($cgi->a({-href => href(action=>"search_help")}, "?")) .
>>  		      " search:\n",
>>  		      $cgi->textfield(-name => "s", -value => $searchtext) . "\n" .
> 
> This should be a separate patch.

I'm sorry, somehow I missed this.

Besides, it would be better to assign return value to some
variable, to avoid calling gitweb_check_feature again... 
-- 
Jakub Narebski
Poland
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]