On Wed, Sep 19, 2012 at 08:22:58PM -0700, Shawn O. Pearce wrote: > On Wed, Sep 19, 2012 at 7:55 PM, Shawn O. Pearce <spearce@xxxxxxxxxxx> wrote: > > From: "Shawn O. Pearce" <spearce@xxxxxxxxxxx> > > I can't explain why git send-email did this. I obviously didn't need > the extra From header here. format-patch didn't write it to the patch > file, it was injected by send-email. My .git/config is pretty simple, > the name/email are derived from there: > > [user] > name = Shawn O. Pearce > email = spearce@xxxxxxxxxxx > > Ick. I really don't want to debug this right now so I'm just going to > pretend it wasn't written. I was looking at the send-email author comparison code a month or three ago, and I remember noticing that it totally fails to canonicalize before comparing. Without even looking at it again, I'm fairly sure that it thinks '"Shawn O. Pearce"' and 'Shawn O. Pearce' (i.e., with and without the quotes) are different, and therefore author != committer. In your case it is particularly egregious because the quotes are introduced (correctly) by format-patch, so it is not even like you have configured two different versions of your name. I think the same bug exists for different rfc2047 encodings of a name with non-ascii characters. Fixing both would involve canonicalizing the names before comparing. I wonder if it would be simpler to just compare the email addresses and ignore the names entirely. -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html