Adam Spiers <git@xxxxxxxxxxxxxx> writes: > On Thu, Sep 20, 2012 at 1:06 AM, Junio C Hamano <gitster@xxxxxxxxx> wrote: >> Adam Spiers <git@xxxxxxxxxxxxxx> writes: >> >>> --- >> >> No explanation why this is a good idea, nor sign-off? > > I realised I forgot the sign-off seconds after sending :-( > > Isn't it completely self-explanatory? e.g. > > test_expect_code: command exited with 0, we wanted 128 git foo bar > > clearly makes more sense than > > test_expect_code: command exited with 0, we wanted 128 from: git foo bar If it were "..., we wanted 128 from 'git foo bar'", then I would, but otherwise, not really. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html