On Wed, Sep 19, 2012 at 09:12:01PM +0100, Adam Spiers wrote: > > > Sounds reasonable, and I think the new output looks nice. I notice that > > > skipped tests are still in green. I wonder if they should be in yellow, > > > too. > > > > > What about blue instead? This would keep the colouring scheme more > > consistent with the one used by prove: > > <http://search.cpan.org/~ovid/Test-Harness/bin/prove> > > by autotest: > > <http://www.gnu.org/software/autoconf/manual/autoconf.html#Using-Autotest> > > and by the Automake-generated test harness: > > <http://www.gnu.org/software/automake/manual/automake.html#Scripts_002dbased-Testsuites> > > Sounds good to me! Blue is the conventional color for informational > signs, so seems like a natural fit for skipped tests. Not sure > whether it should be bold or not though? I'll wait for a more solid > group consensus before re-rolling yet another patch :-) Blue would be fine with me. No strong opinion on bold or not (my gut is that most things should not be bold unless there is a good reason, but that is just a feeling). -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html