On Wed, Sep 19, 2012 at 9:36 AM, Nguyen Thai Ngoc Duy <pclouds@xxxxxxxxx> wrote: > On Wed, Sep 19, 2012 at 2:14 AM, Ralf Thielow <ralf.thielow@xxxxxxxxx> wrote: >> +test_expect_success '--single-branch with explicit --branch tag' ' >> + ( >> + cd dir_tag && git fetch && >> + git for-each-ref refs/tags >../actual >> + ) && >> + git for-each-ref refs/tags >expect && >> + test_cmp expect actual >> +' > > We should have added the tag right after cloning, not until the first > git-fetch. Not that I object how you do it in this patch. Just a note > to myself that if I'm going to do that, I'll need to update this test > to update the change tag before fetching and verify the tag is updated > after git-fetch. > -- > Duy Right. I'll create two tests to replace this one. The first test verifys that the tag has been added after cloning. And in the second test, the tag gets updated in the cloned repository and we verify that the next fetch updates the tag, which catches my "delivery" tag example. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html